Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use bytes for websocket messaging on api #779

Merged
merged 1 commit into from
Dec 14, 2022
Merged

use bytes for websocket messaging on api #779

merged 1 commit into from
Dec 14, 2022

Conversation

en0ma
Copy link
Contributor

@en0ma en0ma commented Dec 14, 2022

No description provided.

alvin-reyes
alvin-reyes approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

10d9e
10d9e approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@10d9e 10d9e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvin-reyes alvin-reyes merged commit 9aa8f1d into dev Dec 14, 2022
@en0ma en0ma deleted the read-and-send-bytes-on-api-websocket branch December 14, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-reyes alvin-reyes alvin-reyes approved these changes

@10d9e 10d9e 10d9e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@en0ma @10d9e @alvin-reyes